Improve detection of non-sharable domains#216
Open
philipp-classen wants to merge 1 commit into
Open
Conversation
philipp-classen
commented
Jul 2, 2026
| // public unless proven otherwise. | ||
| const entry = this.dns.get(hostname); | ||
| return entry?.ip && isLocalIP(entry.ip); | ||
| return false; |
Member
Author
There was a problem hiding this comment.
Subtle change: this used to return "undefined" before. Being also "falsey", it did not make a difference. Only with the tests, it is more explicit.
I thought about even exposing here "undefined" explicitly, but decided against it. Feeling it overall would lead to more confusion than just making the decision here locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak the detection of special domains that should normally never be shared.
Since this is a static check, it will also work on platforms like Safari, where we cannot emulate a DNS resolution (and thus cannot detect private networks based on their IP).