Make whylabs-client less strict #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details:
- include every N {field} on base regex on CronSchedule
- get rid of "strictly 0 {field}" cases, which didn't make sense
- fix order of SplitCron implementation
- checks for "," and "-" cases only on the minute field
- added tests
murilommen
temporarily deployed
to
whylabs-toolkit-ci
GitHub Actions
Inactive
vsuen
approved these changes
Apr 8, 2024
details:
- include every N {field} on base regex on CronSchedule
- get rid of "strictly 0 {field}" cases, which didn't make sense
- fix order of SplitCron implementation
- checks for "," and "-" cases only on the minute field
- added tests
murilommen
temporarily deployed
to
whylabs-toolkit-ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were pinning to the patch version of
whylabs-clientbefore, and this PR relaxes that to the minor now.