making env vars equivalent to whylogs' #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
had a problem deploying
to
whylabs-toolkit-ci
GitHub Actions
Failure
murilommen
temporarily deployed
to
whylabs-toolkit-ci
GitHub Actions
Inactive
vsuen
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whylabs-toolkitrelied on a few env vars that conflicted with ones required bywhylogs. This PR introduces the ability to use both, while adding a few "will be deprecated soon" warning logs in case the old ones are still being used.The idea is that this will not break existing code, but also not hard-require different env vars than what is already set in
whylogs. The changed env vars were:ORG_ID -> WHYLABS_DEFAULT_ORG_ID
DATASET_ID -> WHYLABS_DEFAULT_DATASET_ID
WHYLABS_HOST -> WHYLABS_API_ENDPOINT
ANALYZER_ID -> WHYLABS_DEFAULT_ANALYZER_ID
MONITOR_ID -> WHYLABS_DEFAULT_MONITOR_ID