Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init to allow suppression #1362

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

naddeoa
Copy link
Contributor

@naddeoa naddeoa commented Sep 7, 2023

The new init system can make for confusing demos for existing users and new use cases. Making this suppression option to allow us to avoid output when we don't need to see it.

This is also the first example that was updated to use init, though its a kind of weird case since we don't actually want to display the output in this context.

@naddeoa naddeoa self-assigned this Sep 7, 2023
@naddeoa naddeoa force-pushed the dev/anthony/single-image-example branch 3 times, most recently from 76338d6 to 9da8536 Compare September 7, 2023 23:38
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement over our current output, thanks!

Let's remove that test example notebook from the PR, otherwise looks good!

The new init system can make for confusing demos for existing users and
new use cases. Making this suppression option to allow us to avoid
output when we don't need to see it.
@naddeoa naddeoa force-pushed the dev/anthony/single-image-example branch from 9da8536 to e73e67d Compare September 19, 2023 04:39
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/test_notebooks/notebook_tests.py Show resolved Hide resolved
@jamie256 jamie256 merged commit 619581f into mainline Sep 20, 2023
18 checks passed
@jamie256 jamie256 deleted the dev/anthony/single-image-example branch September 20, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants