Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 7-day old profile warning #1377

Merged
merged 3 commits into from
Sep 19, 2023
Merged

remove 7-day old profile warning #1377

merged 3 commits into from
Sep 19, 2023

Conversation

richard-rogers
Copy link
Contributor

Description

Removes whylabs writer warning for 7-day old profiles.

Closes whylabs/whylogs/#1375

jamie256
jamie256 previously approved these changes Sep 19, 2023
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

Suggest some additional minor cleanup related to removing the logic that detects this specific condition.

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 enabled auto-merge (squash) September 19, 2023 20:41
@jamie256 jamie256 merged commit 338d3d4 into mainline Sep 19, 2023
18 checks passed
@jamie256 jamie256 deleted the dev/richard/1375 branch September 19, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants