Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change a pool-gent metric values to enumerated container status for tracing container status in time series.
Summary (Generated)
This pull request to
pool-agent
includes changes to improve the collection and representation of LXD instance metrics. The most important changes include modifying the way instance statuses are handled and displayed, and updating the associated Prometheus metrics.Improvements to metrics collection:
pool-agent/cmd/agent.go
: ChangedlxdInstances.WithLabelValues
to set the status as a float value usingcontainerStateFromString
instead of incrementing a counter.Enhancements to metrics representation:
pool-agent/cmd/metrics.go
: Added acontainerState
type and constants to represent different container states numerically. ImplementedString
andcontainerStateFromString
methods to convert between string and numeric representations of container states.pool-agent/cmd/metrics.go
: Updated thelxdInstances
help description to include the enumeration of container states. Removed thestatus
label from thelxdInstances
metric.