restore aeon to 'scry-request' response wire#3
Open
sidnym-ladrut wants to merge 1 commit intowicrum-wicrun:masterfrom
Open
restore aeon to 'scry-request' response wire#3sidnym-ladrut wants to merge 1 commit intowicrum-wicrun:masterfrom
sidnym-ladrut wants to merge 1 commit intowicrum-wicrun:masterfrom
Conversation
|
Nice, I think if you made a PR here, it would probably get merged sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the ames ack migration (10d6061), the
aeonparameter was removed from thescry-requestresponse wire, which inadvertently causedapp/simple.hoonto reference unused agent paths.The existing signature for
+tell:da, which also expects theaeonparameter for ascry-request, suggests that this omission was unintentional. This PR simply restores theaeonin this wire with the values it used prior to 10d6061.To test the correctness of this fix, I ran the following test case on two fake ships
~zodand~necwith the SSS desk installed as%simple:Diffing the
dojooutputs before and after the inclusion of this fix yields the following:The fact that the
sub-sum is:line is now being printed after thescry-requestresponse suggests that the fix is working. Feel free to let me know if there are any other tests cases I should run to verify correctness.