Skip to content

restore aeon to 'scry-request' response wire#3

Open
sidnym-ladrut wants to merge 1 commit intowicrum-wicrun:masterfrom
sidnym-ladrut:sl/fix-scry-request-agent-wire
Open

restore aeon to 'scry-request' response wire#3
sidnym-ladrut wants to merge 1 commit intowicrum-wicrun:masterfrom
sidnym-ladrut:sl/fix-scry-request-agent-wire

Conversation

@sidnym-ladrut
Copy link
Copy Markdown

@sidnym-ladrut sidnym-ladrut commented Jul 20, 2023

During the ames ack migration (10d6061), the aeon parameter was removed from the scry-request response wire, which inadvertently caused app/simple.hoon to reference unused agent paths.

The existing signature for +tell:da, which also expects the aeon parameter for a scry-request, suggests that this omission was unintentional. This PR simply restores the aeon in this wire with the values it used prior to 10d6061.

To test the correctness of this fix, I ran the following test case on two fake ships ~zod and ~nec with the SSS desk installed as %simple:

>> ~zod
> :simple &add 1
>> ~nec
> :simple &surf-sum [~zod %sum %foo ~]

Diffing the dojo outputs before and after the inclusion of this fix yields the following:

$ diff log-old.txt log-new.txt
31c31,32
< %simple: on-agent on wire //sss/scry-request/~zod/simple/sum/foo, %poke-ack
---
> %simple: on-agent on wire //sss/scry-request/~zod/simple//sum/foo, %poke-ack
> >   "sub-sum is: ~"

The fact that the sub-sum is: line is now being printed after the scry-request response suggests that the fix is working. Feel free to let me know if there are any other tests cases I should run to verify correctness.

@johnhyde
Copy link
Copy Markdown

johnhyde commented Aug 2, 2023

Nice, I think if you made a PR here, it would probably get merged sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants