Fix #52: Remove incorrect type guard of exists() from mw.Map

wikimedia-gadgets · Dec 19, 2024 · b2cc064 · b2cc064
1 parent 4b5e56c
commit b2cc064
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/mw/Map.d.ts b/mw/Map.d.ts
@@ -28,8 +28,8 @@ export interface ExtensibleMap<V extends Record<string, any>, TX = unknown>
      * @returns True if the key exists
      * @see https://doc.wikimedia.org/mediawiki-core/master/js/mw.Map.html#.exists
      */
-    exists<S extends keyof V>(selection: S): selection is S;
-    exists<S extends string>(selection: S): selection is S;
+    exists(selection: keyof V): boolean;
+    exists(selection: string): boolean;
 
     /**
      * Get the value of one or more keys.
@@ -95,7 +95,7 @@ declare global {
              * @returns True if the key exists
              * @see https://doc.wikimedia.org/mediawiki-core/master/js/mw.Map.html#.exists
              */
-            exists<S extends keyof V>(selection: S): selection is S;
+            exists(selection: keyof V): boolean;
 
             /**
              * Get the value of one or more keys.

diff --git a/test-d/regression/52.test-d.ts b/test-d/regression/52.test-d.ts
@@ -0,0 +1,11 @@
+// https://github.com/wikimedia-gadgets/types-mediawiki/issues/52
+import { expectType } from "tsd";
+
+declare const map: mw.Map;
+declare const k: string;
+
+if (map.exists(k)) {
+    expectType<string>(k);
+} else {
+    expectType<string>(k);
+}