feat: vue module typings, dtslint -> tsd #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sportshead
changed the title
Adds typings for `$i18n` and `Vue.createMwApp`. vue dependency version is locked at 3.3.9, matching the version in mediawiki/core.
dtslint is very broken and expects a very specific setup for DefinitelyTyped repos. Fixes wikimedia-gadgets#25
AnYiEE
added a commit
to AnYiEE/types-mediawiki-renovate
that referenced
this pull request
May 7, 2024
check other authors/commits at wikimedia-gadgets#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typings for
$i18nandVue.createMwApp.vue dependency version is locked at 3.3.9, matching the version in mediawiki/core.
This PR also changes the repo to use tsd instead of dtslint, due to the issues highlighted in #25, and also to fix incorrect lint errors introduced by dtslint when
vueis added as a dependency.