Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting #100

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Add linting #100

merged 3 commits into from
Aug 21, 2024

Conversation

mvolz
Copy link
Collaborator

@mvolz mvolz commented Aug 21, 2024 •
edited
Loading

  • Add linting and fix files accordingly.
  • Remove jshint as covered by eslint.
  • Replace assert with chai in line with other
    wmf node packages.
  • Require node >= 16 and release major version.

@mvolz
Add linting
578b8ea 
*Add linting and fix files accordingly.
*Remove jshint as covered by eslint.
*Replace assert with chai in line with other
wmf node packages.
@mvolz mvolz requested a review from jdforrester August 21, 2024 08:36
@mvolz mvolz marked this pull request as draft August 21, 2024 09:04
@mvolz
[CI] Drop node 14 and add node 20
c542657 
Drop node 14 and add node 20.
@mvolz
Release major version due to node requirements
92548d1 
Drop support for node 14, Requires node >= 16
@mvolz mvolz marked this pull request as ready for review August 21, 2024 09:44
@jdforrester jdforrester merged commit 0febe84 into master Aug 21, 2024
3 checks passed
@jdforrester jdforrester deleted the lint branch August 21, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdforrester jdforrester jdforrester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvolz @jdforrester