Allow custom S3 domain #8
Open
+218
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply changes required to run successfully `shellcheck` on all scripts (see style guide: https://google.github.io/styleguide/shellguide.html#shellcheck) - Fix a few style guide oversights - Fix an incomplete test in `assertArgument()` - Update README to comply with linter issues - Update URL of style guide (as `googlecode.com` no longer exists)
- Add "-d" / "--domain" option to use custom (e.g. private) S3 domain instead of `amazonaws.com` default domain - Update documentation - Update test script
|
Hello @cvle Can you please consider either reviewing this PR or archiving this repo, so that I can apply the proposed change to my own fork of this nice and useful tool? Thanks in advance / Danke schön. |
Commands' help now explain how to use _custom domains_ Signed-off-by: Bailleux Benoît <[email protected]>
- Add the required option to prevent cUrl to display request progress - Add proper copyright and dev. mail address - Add license preamble to `lib/common.sh` file Signed-off-by: Bailleux Benoît <[email protected]>
When a custom domain is specified (with `-d` option), it was not handled the same way as default domain, thus leading to incoherent behavior Change: - Manages custom domain the same way as default one and prepends "s3" or "s3-<region>" as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at allowing user to specify an alternate domain as request target. Thus, it will be possible to use a personal or custom instance of S3-compatible on-line storage service.
Especially useful for companies operating private cloud with S3-compatible service.
Two steps:
First step: lint
The first commit is:
shellcheckon all scripts (see style guide:https://google.github.io/styleguide/shellguide.html#shellcheck)
assertArgument()googlecode.comno longer exists)Second step: new feature
The new feature has been proposed in second commit
It adds a
-dor--domaincommand-line option (or make use ofS3_DEFAULT_DOMAINenv. var.) to replace default domain (i.e. s3.amazonaws.com) with custom domain