Skip to content

chore: add ymlfmt and format exisiting YAML files#1652

Merged
lapla-cogito merged 7 commits intowild-linker:mainfrom
fahdfady:yamlfmt
Mar 6, 2026
Merged

chore: add ymlfmt and format exisiting YAML files#1652
lapla-cogito merged 7 commits intowild-linker:mainfrom
fahdfady:yamlfmt

Conversation

@fahdfady
Copy link
Copy Markdown
Contributor

@fahdfady fahdfady commented Mar 6, 2026

resolves #1650

  • this uses yamlfmt to keep a standard of yaml files formatting via a .yamlfmt config file
  • adds a CI step to check yaml files formatting
  • format existing yaml files

@fahdfady
Copy link
Copy Markdown
Contributor Author

fahdfady commented Mar 6, 2026

should i add this to the CONTRIBUTING.md docs or the nix dev shell?

Copy link
Copy Markdown
Member

@davidlattimore davidlattimore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add something to CONTRIBUTING.md about it, including a link to yamlfmt. Are you intending to verify the formatting somehow? Perhaps from a test?

@fahdfady
Copy link
Copy Markdown
Contributor Author

fahdfady commented Mar 6, 2026

Are you intending to verify the formatting somehow? Perhaps from a test?

Yes. Provided here:
https://github.com/wild-linker/wild/pull/1652/changes#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR138-R151
I'm waiting for the actions to run on this PR to see if it's working or not. I will also intentionally mess up the formatting to see how it fails in the CI then revert back

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Copy link
Copy Markdown
Member

@lapla-cogito lapla-cogito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lapla-cogito lapla-cogito merged commit f351a7e into wild-linker:main Mar 6, 2026
27 checks passed
@mati865
Copy link
Copy Markdown
Member

mati865 commented Mar 7, 2026

There is something wrong with this change: Warning: Restore cache failed: Dependencies file is not found in /home/runner/work/wild/wild. Supported file pattern: go.mod
https://github.com/wild-linker/wild/actions/runs/22790352787/job/66115576377#step:3:26

@fahdfady
Copy link
Copy Markdown
Contributor Author

fahdfady commented Mar 7, 2026

I think it's looking for a go.mod while installing yamlfmt inside the repo but couldn't find it. I think this is harmless, we don't need to add a go.mod just for the yamlfmt package.

@mati865
Copy link
Copy Markdown
Member

mati865 commented Mar 15, 2026

Fixed in #1696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a YAML Autoformatter

4 participants