fix: only keep RELRO_PADDING section when relro is enabled#1892
Merged
lapla-cogito merged 1 commit intowild-linker:mainfrom May 5, 2026
Merged
fix: only keep RELRO_PADDING section when relro is enabled#1892lapla-cogito merged 1 commit intowild-linker:mainfrom
lapla-cogito merged 1 commit intowild-linker:mainfrom
Conversation
TechnoPorg
force-pushed
the
push-vwvnvorqqxmp
branch
from
ca49f83 to
072a6a0
Compare
lapla-cogito
reviewed
May 5, 2026
TechnoPorg
force-pushed
the
push-vwvnvorqqxmp
branch
from
072a6a0 to
2132614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #1884 (comment), the check in
apply_force_keep_sectionsto only keep the RELRO_PADDING section is overridden by the fact that the section is unconditionally kept a few lines above.New ExpectProgramHeader/NoProgramHeader test directives have been added here to test this behaviour.