ci: run tests on Mach-O (skip ELF tests), reorder CI jobs#1895
Merged
marxin merged 7 commits intowild-linker:mainfrom May 7, 2026
Merged
ci: run tests on Mach-O (skip ELF tests), reorder CI jobs#1895marxin merged 7 commits intowild-linker:mainfrom
marxin merged 7 commits intowild-linker:mainfrom
Conversation
db1eb74 to
dcb4c66
Compare
2dae283 to
67cd8e7
Compare
67cd8e7 to
9df23f8
Compare
Member
|
It seems reasonable to not run Linux tests on Mac, but why not continue to run Mac tests on Linux? When doing refactorings (on Linux), it's very useful to be able to at least verify that the Mac code paths in the linker still run OK. |
Collaborator
Author
|
Works for me! Part of the PR is also a reordering of the CI jobs so that we have them grouped by platform (Linux, wasip1, Mach-O, Windows). Hope it makes sense. |
davidlattimore
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
integration_tests, the ELF tests are run (linked) even on Mach-O, but there are 2 fundamental problems with the approach:/usr/bin/ldon Mach-O is a system linker that does not support the ELF options:gcc) does not produce ELF files:That's why I tentatively suggest dropping the cross-platform capability of the integrations tests. Thoughts once that @davidlattimore?