-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-18768] OpenShift support for the mail quickstart #923
base: main
Are you sure you want to change the base?
Conversation
Hi @Dkafetzis. Thanks for your PR. I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hi @Dkafetzis , I am delegating review to @yersan , who leads mail's component |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Dkafetzis , you did great work with this, thanks!
I've added minor notes to review, also, when I compile the mail server locally, the readme.html generated does not contain all the steps related to helm charts and OpenShift, what is the trick to read the final documentation generated from this soruces?
mail/README.adoc
Outdated
== Deploy the {ProductShortName} Source-to-Image (S2I) Quickstart to OpenShift with Helm Charts | ||
|
||
Log in to your OpenShift instance using the `oc login` command. | ||
The backend will be built and deployed on OpenShift with a Helm Chart for {productName}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/The backend will be built and deployed/The application will be built and deployed
Named it backend here does not sound correct to me, it is not a backend that exposes any API to other front-end applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of a shared doc that gets generated once the asciidoctor flattens the README-source.adoc file. So it is the same for everyone that references it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI no need to update manually this file, once the PR is merged this will be auto updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yersan FYI you can use -Pdocs or -Drelease to rebuild the html
dcd43d1
to
e72a2f6
Compare
@yersan Applied the suggested changes. Also fixed the Readme, it should now generate correctly. |
e72a2f6
to
d373165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me. If CI testing is green and @yersan approves too I will merge it.
d373165
to
458756a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that Kubernetes support will be needed to overcome the CI fail, but this can be done in a separated JIRA and PR. In case you want to do it here and now please let me know so I point you in the right direction.
@emmartins I'd like to also add support for kubernetes on the quickstart but In another issue since this is not part of Openshift and this one has been open for a long time. |
@Dkafetzis FYI not forgotten, just waiting for additional @kstekovi review, who will later add some testing changes on top of your work, this may take a week or more |
https://issues.redhat.com/browse/WFLY-18768