Skip to content

Clean the CI setup #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monteiro merged 2 commits into from
Feb 20, 2025
Merged

Clean the CI setup #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c495a
Clean the CI setup
stof Oct 21, 2024
9be10cf
Fix deprecation for implicit nullable parameters
stof Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 6 additions & 25 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,16 @@ jobs:
continue-on-error: ${{ matrix.allowed-to-fail }}

strategy:
fail-fast: false
matrix:
php-version: ['7.4', '8.0', '8.1']
variant: [normal]
php-version: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
dependencies: [highest]
allowed-to-fail: [true]
allowed-to-fail: [false]
symfony-version: [latest]
include:
- php-version: '7.4'
- php-version: nightly
dependencies: highest
variant: normal
allowed-to-fail: false
symfony-version: latest
- php-version: '8.0'
dependencies: highest
variant: normal
allowed-to-fail: false
symfony-version: latest
- php-version: '8.1'
dependencies: highest
variant: normal
allowed-to-fail: false
allowed-to-fail: true
symfony-version: latest
steps:
- name: "Checkout code"
Expand All @@ -53,16 +42,8 @@ jobs:
tools: composer:v2
extensions: intl, xdebug

- name: "Set composer cache directory"
id: composer-cache
run: echo "::set-output name=dir::$(composer config cache-files-dir)"

- name: Install variant
if: matrix.variant != 'normal'
run: composer require ${{ matrix.variant }} --no-update

- name: "Install Composer dependencies (${{ matrix.dependencies }})"
uses: "ramsey/composer-install@v1"
uses: "ramsey/composer-install@v3"
with:
dependency-versions: "${{ matrix.dependencies }}"
composer-options: "--prefer-dist"
Expand Down
4 changes: 2 additions & 2 deletions Dumper/TranslationDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ public function addLoader($id, $loader)
* @param string $target Target directory.
* @param string $pattern route path
* @param string[] $formats Formats to generate.
* @param \stdClass $merge Merge options.
* @param \stdClass|null $merge Merge options.
*/
public function dump(
$target = 'web/js',
$pattern = self::DEFAULT_TRANSLATION_PATTERN,
array $formats = array(),
\stdClass $merge = null
?\stdClass $merge = null
) {
$availableFormats = array('js', 'json');

Expand Down