Symfony 8 support.

[AdamReece-WebBox]

Amendments for Symfony 8 support:

• Converted configurations from XML to PHP format using this tool: https://github.com/GromNaN/symfony-config-xml-to-php/
• Retained comments from XML configurations.
• Changed extension class for dependency injection to use PhpFileLoader instead of XmlFileLoader.
• Removed XML configurations.

Test suite results:

PHPUnit 8.5.50 by Sebastian Bergmann and contributors.

Testing BazingaJsTranslationBundle Test Suite
[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
[error] Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "" at Controller.php line 122
[info] Matched route "bazinga_jstranslation_js".
[error] Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "" at Controller.php line 122
[info] Matched route "bazinga_jstranslation_js".
[error] Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "" at Controller.php line 122
.[info] Matched route "bazinga_jstranslation_js".
[error] Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "" at Controller.php line 122
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
.[info] Matched route "bazinga_jstranslation_js".
............                                     29 / 29 (100%)

Time: 3.86 seconds, Memory: 16.00 MB

OK (29 tests, 127 assertions)

Unsure if the 4 NotFoundHttpException instances are from this change. When running the same test on master it failed entirely due to XmlFileLoader no longer being available.

[stof]

This requires bumping the min version of Symfony being supported though.

Symfony 4.4 does support the PHP DSL for config files.

[andzelikakustra]

Hello :) Can we expect compatibility with Symfony 8 in the near future?

[AdamReece-WebBox]

Hello :) Can we expect compatibility with Symfony 8 in the near future?

I completely forgot about this. The PR had some feedback to acknowledge.

[AdamReece-WebBox]

This requires bumping the min version of Symfony being supported though.

Symfony 4.4 does support the PHP DSL for config files.

It looks like 4.4 is already the minimum version supported. Does this just require 8.0 being added to the Composer package requirements?

    "require": {
        "php": ">=7.4",
        "symfony/framework-bundle": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/finder": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/console": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/intl": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/translation":  "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/twig-bundle": "~4.4|~5.0|~6.0|~7.0|~8.0"
    },
    "require-dev": {
        "symfony/asset": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/filesystem": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/yaml": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/browser-kit": "~4.4|~5.0|~6.0|~7.0|~8.0",
        "symfony/phpunit-bridge": "^5.0|^6.0|~7.0|~8.0",
        "phpunit/phpunit": "^4.8|~5.7|~6.5|~8"
    },

[stof]

There is a typo in my previous message. It should read "does not support"

[Wiktor6]

@AdamReece-WebBox @stof it there any chance to update this PR and merge? :)

[andzelikakustra]

Hello, is there a chance for acceptance and merge? @AdamReece-WebBox @stof

[stof]

I don't have write access to this repo, so I cannot merge PRs. The maintainer is @monteiro.

I'm helping with reviews on this bundle because I know it well and I know Symfony quite well (and because I'm using it at work, so I'm interested in getting Symfony 8 support as well).

[AdamReece-WebBox]

This might need squashing first. I did try this for commit 4e9497d, not sure if that's done right.

[monteiro]

Hi @AdamReece-WebBox , thank you very much for your PR, and sorry for taking it so long to answer.
I have fixed this PR: #374 and also dropped Symfony
4.4 and some PHP versions.

Let me know if I forgot anything!