Improvements to Type Hinting and Object Model #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to run the unit tests, PHPUnit is a hard dev dependency, so I've included it in this commit, and now I can run the unit tests as part of this PR.
This is for willdurand#89 - to ensure correct type hints are provided to developers who use IDEs.
Fixes willdurand#89 - IDEs and PHPStan are happy with this implementation
* Depend on PHPUnit for development In order to run the unit tests, PHPUnit is a hard dev dependency, so I've included it in this commit, and now I can run the unit tests as part of this PR. * Depend on PHPStan for development This is for willdurand#89 - to ensure correct type hints are provided to developers who use IDEs. * Fix object model of AcceptHeader interface Fixes willdurand#89 - IDEs and PHPStan are happy with this implementation * Correct return type * Correct nonexistent Priority class to AcceptHeader * Improve typehint - allow looser type to be returned * Improve typehint - more accurate types as parameters * Improve typehint - more accurate generics as parameters * Expose script property - was only ever written * Properly typehint associative array * Typehint nullable string * Match typehints of parent method * Add PHPStan to CI * Configure PHPUnit versions for different PHP runtimes * Use real phpunit
|
You should split this: it really is 3 PR in one:
All those are independent concerns, by tying them all together in one PR, you take the risk that none ever get fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #89 - IDEs will not complain about the use of type hints or object inheritance any more.
I have used PHPStan set to level 5 checks to expose any ambiguous/incorrect uses of type hinting. My IDE is happy now!