Skip to content

Commit

Permalink
fix(pypi): exclude python3.12 from candidate list (#1722)
Browse files Browse the repository at this point in the history
Support for python3.12 among pypi packages is pretty poor, this limits the upper bound to python3.11 instead.
  • Loading branch information
williamboman committed May 31, 2024
1 parent 49ff59a commit f8ce876
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion lua/mason-core/installer/managers/pypi.lua
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ local function get_versioned_candidates(min_version)
return Optional.empty()
end
end, {
{ semver.new "3.12.0", "python3.12" },
{ semver.new "3.11.0", "python3.11" },
{ semver.new "3.10.0", "python3.10" },
{ semver.new "3.9.0", "python3.9" },
Expand Down
2 changes: 1 addition & 1 deletion tests/mason-core/installer/managers/pypi_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ end
describe("pypi manager", function()
before_each(function()
stub(spawn, "python3", mockx.returns(Result.success()))
spawn.python3.on_call_with({ "--version" }).returns(Result.success { stdout = "Python 3.12.0" })
spawn.python3.on_call_with({ "--version" }).returns(Result.success { stdout = "Python 3.11.0" })
end)

it("should init venv without upgrading pip", function()
Expand Down

0 comments on commit f8ce876

Please sign in to comment.