Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let python lsps and debuggers access installed packages #1584

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lua/mason-core/installer/managers/pypi.lua
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ local function create_venv()
end
log.fmt_debug("Found python3 installation version=%s, executable=%s", target.version, target.executable)
ctx.stdio_sink.stdout "Creating virtual environment…\n"
return ctx.spawn[target.executable] { "-m", "venv", VENV_DIR }
return ctx.spawn[target.executable] { "-m", "venv", "--system-site-packages", VENV_DIR }
end

---@param ctx InstallContext
Expand Down Expand Up @@ -112,6 +112,7 @@ local function pip_install(pkgs, extra_args)
"pip",
"--disable-pip-version-check",
"install",
"--ignore-installed",
"-U",
extra_args or vim.NIL,
pkgs,
Expand Down
6 changes: 6 additions & 0 deletions tests/mason-core/installer/managers/pypi_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ describe("pypi manager", function()
assert.spy(ctx.spawn.python3).was_called_with {
"-m",
"venv",
"--system-site-packages",
"venv",
}
end)
Expand All @@ -55,6 +56,7 @@ describe("pypi manager", function()
assert.spy(ctx.spawn.python3).was_called_with {
"-m",
"venv",
"--system-site-packages",
"venv",
}
assert.spy(ctx.spawn[venv_py(ctx)]).was_called(1)
Expand All @@ -63,6 +65,7 @@ describe("pypi manager", function()
"pip",
"--disable-pip-version-check",
"install",
"--ignore-installed",
"-U",
{ "--proxy", "http://localhost" },
{ "pip" },
Expand All @@ -83,6 +86,7 @@ describe("pypi manager", function()
"pip",
"--disable-pip-version-check",
"install",
"--ignore-installed",
"-U",
vim.NIL, -- install_extra_args
{
Expand Down Expand Up @@ -122,6 +126,7 @@ describe("pypi manager", function()
"pip",
"--disable-pip-version-check",
"install",
"--ignore-installed",
"-U",
vim.NIL, -- install_extra_args
{
Expand All @@ -148,6 +153,7 @@ describe("pypi manager", function()
"pip",
"--disable-pip-version-check",
"install",
"--ignore-installed",
"-U",
{ "--proxy", "http://localhost:9000" },
{
Expand Down
Loading