Show next alert time in notification #90
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this look like the right approach? |
|
Just wanted to say thanks for the PR! I'll wait to fully review until your marked ready for review. But could you add a screenshot and some tests for the message generation? |
williscool
reviewed
Jun 5, 2025
| val duration = nextAlertTime - clock.currentTimeMillis() | ||
| if (duration > 0) { | ||
| sb.append(" (") | ||
| sb.append(ctx.getString(R.string.next_alert_in)) |
There was a problem hiding this comment.
Does this R string exist yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows the next alert time (if setting enabled, and if there is a next alert time), in the notification
Closes #89
Todo:
EventRecordtoEventFormatter.formatNotificationSecondaryText()