Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vary header for Hx-Requests #103

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add Vary header for Hx-Requests #103

merged 1 commit into from
Apr 12, 2024

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Apr 10, 2024

The HTMX docs recommend doing this to avoid issues with caches returning partial results. https://htmx.org/docs/#caching

@wimdeblauwe
Copy link
Owner

Thanks! I see the build is failing, because /hx-vary endpoint does not exist. Did you forget to commit something?

The HTMX docs recommend doing this to avoid issues with caches
returning partial results.
@wimdeblauwe
Copy link
Owner

Thanks for your remark @xhaggi ! @dsyer Is it ok for you to merge now?

@dsyer
Copy link
Contributor Author

dsyer commented Apr 12, 2024

Yes please.

@wimdeblauwe wimdeblauwe merged commit 81e14a6 into wimdeblauwe:main Apr 12, 2024
2 checks passed
@wimdeblauwe
Copy link
Owner

Version 3.3.0 is now released with this included: https://github.com/wimdeblauwe/htmx-spring-boot/releases/tag/3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants