-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing response headers #117
Conversation
I would definitely prefer if you cherry pick the commits so that you have one per annotation and not to lose the author of the commits. @wimdeblauwe or do you have a different opinion on this? |
@xhaggi |
/** | ||
* How the response will be swapped in relative to the target | ||
*/ | ||
String swap() default ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use HxSwapType
here ?
I like small commits for sure, but I think this is a nice whole. I don't see much need for separate commits for each annotation. That said, maybe @tschuehly can do a force commit with an added line in the commit message using |
@tschuehly I really appreciate your work, but I like to stick to separate commits and the original work I did. That's why I did it on my own and created a separate PR #118 for it. I hope this is OK for you? Maybe you should have asked in #105 if I could do the rebase and a PR, I certainly would have done it. BTW it only took me a few minutes. |
Well now it doesn't matter 😁 |
As discussed in #105 this is the work of @xhaggi rebased on the current main and fixed to align with the current version
source: https://github.com/xhaggi/htmx-spring-boot/tree/missing-response-headers