Add tests for Serf #114
Merged
Add tests for Serf #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohkinozomu
force-pushed
the
add-serf-test
branch
from
b244475 to
009e834
Compare
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that in Serf, nodes that have called
Leave()still remain in the members with theStatusLeftstate.NumMembers()returns a value that includes nodes with theStatusLeftstate, which I believe does not meet user expectations.I have modified it to return only nodes with the
StatusAlivestate.Since
NumMembers()is not currently being used, I have removed it from the Node interface.