feat: allow deploying worker groups as statefulsets #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rubenfiszel just pinging you in case you didn't see this, apologies for the noise |
|
It looks great, I will review this week. Thanks for the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows deploying worker groups as StatefulSets instead of Deployments and adds support for
volumeClaimTemplateswhich are StatefulSet-specific.The use case for this would be to have a separate persistent and stable volume per pod in a worker group.
I've tested this on my own Windmill deployment, and I can confirm it works and doesn't introduce any breaking changes.