Skip to content

chore(git_sync): UI improvements for workspace settings #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(git_sync): UI improvements for workspace settings #7177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7cf561
chore(git_sync): remove 'configure initial sync settings' text
github-actions[bot] Nov 19, 2025
5987b5b
chore(git_sync): change 'initialize git repository' button color to blue
github-actions[bot] Nov 19, 2025
0075651
fix
centdix Nov 19, 2025
692d77c
bigger
centdix Nov 19, 2025
87aa849
fix
centdix Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/src/lib/components/git_sync/DetectionFlow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@

<!-- Initialize button -->
<div class="flex justify-start">
<Button size="md" onclick={handleInitialize} startIcon={{ icon: Save }}>
<Button size="md" onclick={handleInitialize} startIcon={{ icon: Save }} variant="accent">
Initialize Git repository
</Button>
</div>
Expand All @@ -163,7 +163,12 @@

<!-- Save connection button -->
<div class="flex justify-start">
<Button size="md" onclick={handleSaveConnection} startIcon={{ icon: Save }}>
<Button
size="md"
onclick={handleSaveConnection}
startIcon={{ icon: Save }}
variant="accent"
>
Save connection
</Button>
</div>
Expand Down
30 changes: 6 additions & 24 deletions frontend/src/lib/components/git_sync/GitSyncRepositoryCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,13 +234,7 @@
{/if}
{#if !confirmingDelete}
<div transition:fade|local={{ duration: 100 }}>
<Button
size="xs"
variant="default"
onclick={initiateDelete}
startIcon={{ icon: Trash }}
destructive
>
<Button size="xs" onclick={initiateDelete} startIcon={{ icon: Trash }} destructive>
Delete
</Button>
</div>
Expand Down Expand Up @@ -278,12 +272,7 @@
/>
</div>
{#if !emptyString(repo.git_repo_resource_path)}
<Button
disabled={emptyString(repo.script_path)}
variant="accent"
onclick={runGitSyncTestJob}
size="xs"
>
<Button disabled={emptyString(repo.script_path)} onclick={runGitSyncTestJob} size="xs">
Copy link
Contributor Author

@claude claude bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variant="accent" was removed here. Was this intentional? This reduces the visual prominence of the "Test connection" button. If this was intentional to create better visual hierarchy (making "Pull from repo" and "Push to repo" more prominent), consider keeping it. Otherwise, you may want to restore the accent variant.

Test connection
</Button>
{/if}
Expand Down Expand Up @@ -360,10 +349,7 @@

<!-- Configuration -->
{#if repo.isUnsavedConnection && !emptyString(repo.git_repo_resource_path) && idx !== null}
<DetectionFlow
{idx}
mode={repoMode}
/>
<DetectionFlow {idx} mode={repoMode} />
{:else}
<GitSyncFilterSettings
bind:git_repo_resource_path={repo.git_repo_resource_path}
Expand All @@ -388,11 +374,7 @@
<div class="flex justify-between items-start">
<!-- Display mode settings as prominent text -->
<div class="flex-1 mr-4">
<GitSyncModeDisplay
mode={repoMode}
{targetBranch}
repository={repo}
/>
<GitSyncModeDisplay mode={repoMode} {targetBranch} repository={repo} />
</div>

<!-- Manual sync section for existing repos -->
Expand All @@ -402,15 +384,15 @@
<div class="flex gap-2">
<Button
size="xs"
variant="default"
variant="accent"
onclick={() => idx !== null && gitSyncContext.showPullModal(idx)}
startIcon={{ icon: Download }}
>
Pull from repo
</Button>
<Button
size="xs"
variant="default"
variant="accent"
onclick={() => idx !== null && gitSyncContext.showPushModal(idx)}
startIcon={{ icon: Upload }}
>
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/lib/components/git_sync/GitSyncSection.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@

// Check if any secondary repositories are unsaved
const hasUnsavedSecondary = $derived(secondarySync.some((s) => s.repo.isUnsavedConnection))
const hasUnsavedSecondaryPromotion = $derived(secondaryPromotion.some((s) => s.repo.isUnsavedConnection))
const hasUnsavedSecondaryPromotion = $derived(
secondaryPromotion.some((s) => s.repo.isUnsavedConnection)
)
</script>

{#if !gitSyncContext}
Expand Down Expand Up @@ -74,7 +76,6 @@
{#if $enterpriseLicense && gitSyncContext.repositories != undefined}
<div class="flex mt-5 mb-5 gap-8">
<Button
variant="accent"
target="_blank"
endIcon={{ icon: ExternalLink }}
href={`/runs?job_kinds=deploymentcallbacks&workspace=${$workspaceStore}`}
Expand Down
5 changes: 0 additions & 5 deletions frontend/src/lib/components/workspaceSettings/GitSyncFilterSettings.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,6 @@
</div>
</div>
</div>
<div class="mt-6 p-2 border-t">
<div class="text-xs text-primary mb-2">
{isInitialSetup ? 'Configure initial sync settings' : 'Review migration settings'}
</div>
</div>
{:else}
<!-- Read-only view -->
<div class="px-4 py-2">
Expand Down
Loading