forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CalculateRoute] #1
Draft
winest
wants to merge
2
commits into
main
Choose a base branch
from
billyhung/new_calculate_route_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Mapped request fields 2. TODO: Move common fields such as coordinates to new struct 3. TODO: Mapped response fields
winest
pushed a commit
that referenced
this pull request
Jul 4, 2023
…iew/2023-01-01-preview (Azure#23056) * Generate new Service for help * init commit microsoft.help-2023-01-01-preview * Updating swagger documentation #1 * Updating swagger documentation Azure#2 * Adding suppressions for Help 2023-01-01-preview api * Adding suppressions for Help 2023-01-01-preview api Azure#2 * removed unnecessary files * update examples
winest
pushed a commit
that referenced
this pull request
Jul 4, 2023
* Adding translator API definition (#1) * Adding translator API definition * Fixing PR comments, part 1 * Fixes and python * Add versions * fix PR comments * fix operation definition * Enable all operations and dotnet * Fixes for languages API * Double clients and new auth method * PR comment fix * Switch to custom operations * Removing the APIM client * Adding emitters * Update api-version * Updates to models * Attempt to fix the api-version * Fixing API version * Fix dictionaries. * Fix the models * Models fixes * Removing detect, fix breaksentence * Adding examples * Fixing languages endpoint * Updating generation --------- Co-authored-by: Michal Materna <[email protected]> Co-authored-by: Catalina Peralta <[email protected]> * Fix the packages names * Update model names * Move files * Switch to knowValues * Reuse transliteration text models * Migrate to TSP * Updating TS files to satisfy pipeline * Adding autorest * Adding swagger file * Adding examples * Fixing path to examples * Speel check fix * Updating name of TS exporter * Updating openapi.json * Linting, spell check fixes * Fix spelling * Test removing generators * Fixing BS example * Fixing model generation * Update examples * Prettier * Generate new openapi.json * adding azure-resource-provider-folder config * Suppress warning * Remove sdk-for-net-track2 * Changing the name of the folder as per PR comment --------- Co-authored-by: Michal Materna <[email protected]> Co-authored-by: Catalina Peralta <[email protected]>
winest
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Adds base for updating Microsoft.AppPlatform from version preview/2023-11-01-preview to version 2024-01-01-preview * Updates readme * Updates API version in new specs and examples * add cspell exclusion (Azure#26987) * Add option for Application Configuration Service refresh interval (Azure#26943) * add the option for acs refresh interval * refine description and complete examples * feat: Add Java 21 (Azure#26946) * add buildpacks version (Azure#26933) * Update appplatform.json * Update BuildServiceBuilder_Get.json * Update BuildServiceBuilder_List.json * Update BuildServiceBuilder_CreateOrUpdate.json * Update language specific readme.md for 2024-01-01-preview api version (Azure#27041) * Cherry latest stable branch change to preview API version (Azure#27063) * e94094b * 4a35b74 * f3e4338 * 4a35b74 * a92c321 * 9a93245 * a693dc6 * fix lint * fix lint * add buildpacks version (Azure#27061) * Update appplatform.json * Update BuildServiceBuilder_Get.json * Update BuildServiceBuilder_List.json * Update BuildServiceBuilder_CreateOrUpdate.json * Update BuildService_GetSupportedBuildpack.json * Update readme.md (Azure#27095) * Short lived app support (Azure#26958) * Short lived app support * Rename type to kind * add cancelled (#1) * Add testEndpointAuthState to AppResourceProperties (Azure#26938) * add disable test endpoint auth to AppResourceProperties * Update Apps_CreateOrUpdate_VNetInjection.json * Update Apps_CreateOrUpdate.json * Update Apps_Get.json * Update Apps_Get_VNetInjection.json * Update Apps_List.json * Update Apps_List_VNetInjection.json * Update Apps_SetActiveDeployments.json * Update Apps_Update.json * Update Apps_Update_VNetInjection.json * use enum for test endpoint auth * remove api version from readme.python.md * revert short lived app API (Azure#27196) * adding version for python sdk temporarily for python sdk generation --------- Co-authored-by: Jeff <[email protected]> Co-authored-by: Qingyi Liu <[email protected]> Co-authored-by: Yuwei Zhou <[email protected]> Co-authored-by: ninpan-ms <[email protected]> Co-authored-by: Sandy Cai <[email protected]>
winest
pushed a commit
that referenced
this pull request
Jul 2, 2024
…onvmaypreview ga (Azure#28841) * Add examples and api version for May GA and Preview * Add Aspect related tsp changes * Some API version corrections * Remove Custom Conv Summarization examples from May GA examples * minor api adjustments for other custom conv summarization attributes * Add an example and specifications for entity tags (#1) * compile fixes * Add examples * Examples changes * Changes to remove older preview API version in Analyze conversations * Fix compile error and add compiled swagger json * Fix some avocado and prettier check issues * Fix some more lintdiff and avocado errors * Correct Readme * Fix typespec validation * Address minor documenatation comment --------- Co-authored-by: Aurgho Bhattacharjee <[email protected]> Co-authored-by: nithya4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new unified Routing API for both Azure Maps and Bing Maps Enterprise users.
Truck routing is going to be removed from Bing Maps so we will proxy truck routing to TomTom.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links