Wakeup on close port #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test that opens a pipe and spawns a fiber which reads from it. The pipe then gets closed and the test checks if the fiber gets scheduled again.
As the FIXME points out, the finalize function may be invoked from a finalizer-thread. To avoid races with the scheduler thread, spawn a fiber on the scheduler that handles the fd to cleanup the fd-waiters. Also ensure that all waiters waiting on the closed fd get scheduled again, as they would otherwise wait forever.
D4ryus
force-pushed
the
wakeup-on-close-port
branch
from
241b18a
to
21ef73b
Compare
emixa-d
added
bug
needs-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The first commit adds a test that fails on current master due to fibers
not getting scheduled again when their port gets closed. This is fixed
by the second commit. I am not sure if we could still run into problems
with the
hashv-set!when the scheduled task gets stolen from anotherscheduler by
steal-work!.