Explicitly add msys2 as path dependency of libadwaita
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `libadwaita` 1.4.0, the `demo/data/meson.build` was changed to require `sh` [1]. However, this is causing a `Program 'sh' not found` error in `gvsbuild` because `sh` isn't on the `$PATH` by default. Resolve this by adding MSYS2's `sh` to the `$PATH`. Fixes wingtk#1133 [1] https://gitlab.gnome.org/GNOME/libadwaita/-/commit/daeb5a6b78a8530b78f7d495deb02f4e97f26e7b
mitchhentges
force-pushed
the
libadwaita-missing-sh
branch
from
633f13a to
b8bfb8b
Compare
|
It looks like this wasn't caught by CI because CI specifies It's unclear to me how to solve this without doubling the CI matrix (GTK 3, 4 and with/without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
libadwaita1.4.0, thedemo/data/meson.buildwas changed to requiresh[1].However, this is causing a
Program 'sh' not founderror ingvsbuildbecauseshisn't on the$PATHby default.Resolve this by adding MSYS2's
shto the$PATH.Fixes #1133
[1] https://gitlab.gnome.org/GNOME/libadwaita/-/commit/daeb5a6b78a8530b78f7d495deb02f4e97f26e7b