Skip to content

fix(dispatch): handle #[...] attributes#619

Draft
39555 wants to merge 2 commits intowinnow-rs:mainfrom
39555:dispatch-cfg-attributes
Draft

fix(dispatch): handle #[...] attributes#619
39555 wants to merge 2 commits intowinnow-rs:mainfrom
39555:dispatch-cfg-attributes

Conversation

@39555
Copy link
Contributor

@39555 39555 commented Nov 14, 2024

Closes: #609

Handle #[...] attributes in dispatch! macro

@39555 39555 force-pushed the dispatch-cfg-attributes branch from f21886a to 65c7f14 Compare November 14, 2024 13:54
@epage epage mentioned this pull request Nov 18, 2024
2 tasks
@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11909745800

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 41.709%

Totals Coverage Status
Change from base Build 11802515306: 0.1%
Covered Lines: 1303
Relevant Lines: 3124

💛 - Coveralls

@39555
Copy link
Contributor Author

39555 commented Nov 19, 2024

This is not related to the Pratt prs. I just resolved an issue that I knew how to fix by the way

@epage
Copy link
Collaborator

epage commented Nov 19, 2024

I appreciate it!

I bet seq! could also benefit from this ;)

(no obligation and not a blocker for this PR; incremental improvement is great!)

@epage
Copy link
Collaborator

epage commented Nov 19, 2024

As this is still a draft, I'm mostly holding off for now. Let me know when its ready (I don't think I get notifications for that) and please clean up the commits for how you want them reviewed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dispatch! unable to handle cfg attributes

3 participants

Comments