Fold the copies of one foreign post into a single card - #2197
Merged
Conversation
Ein Beitrag wird pro Server einmal gespeichert, also stand derselbe Text zwei- oder dreimal im Feed und auf der Tagseite, jedes Mal identisch bis auf die "Gefunden über"-Zeile, und die Zahl darüber zählte Zeilen statt Beiträge: auf einer Produktionskopie 78 Zeilen für 50 Originale und eine Tagseite mit 20 Karten für 9 Beiträge. Die Karte kommt jetzt aus der Kopie vom Heimatserver des Autors, wenn wir eine halten, sonst aus der zuerst gespeicherten; die übrigen Server werden zu einer aufklappbaren Zeile in der Geometrie, in der sich die Fediverse-Reaktionen schon falten. Gefaltet wird vor dem Blättern, über den ganzen Bestand, den eine Oberfläche zeigen darf, damit die Zahl stimmt und eine vom LIMIT geteilte Gruppe nicht auf der nächsten Seite ein zweites Mal auftaucht. Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das problematisch ist. Claude-Session: https://claude.ai/code/session_01AW11tx7rYiSEaRDjPFNghY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same post read off three servers was three cards in the feed and on the tag page, each identical to the one above it but for its "found through" line, and the figure over the list counted rows: on a production copy 78 stored rows for 50 originals, and
/tags/internationalsandwichasong?source=fediversedrawing 20 cards for 9 posts.One card now stands for the original. It is drawn from the copy the author's own server served where we hold one (6 of the 50) and otherwise from the copy stored first; the other servers become a disclosure — "Found through these servers" with the count, opening to the list — in the geometry a post's fediverse reactions already fold into, which both now share. The fold runs over the whole scope a surface may show before it pages it, so the count is right and a group split by a page's
LIMITcannot come back on the next page.Reporting is unchanged and the surfaces now hold its promise: a relayed card loses one server and stays, the author's own card takes every copy and goes.
Where:
Vutuv.Tags.ExternalPosts.fold_copies/1,<.external_post_card>.Closes #2163
https://claude.ai/code/session_01AW11tx7rYiSEaRDjPFNghY