New accounts see no ads for their first two weeks - #2249
Merged
Merged
Conversation
Die ersten Tage nach der Anmeldung entscheiden, ob jemand bleibt, und
die Werbung eines Fremden ist das falsche Erste, was man dort trifft.
Vutuv.Ads.eligible?/2 nimmt deshalb jetzt den ganzen %User{} statt zwei
herausgegriffener Spalten und liest neben ad_seen_at und
ads_dismissed_on auch inserted_at; wer keine 14 Tage dabei ist, bekommt
den Platz gar nicht besetzt, Hausanzeige eingeschlossen. Die alte
Signatur ließ den Aufrufer entscheiden, welche Spalten die Regel sehen
darf, und genau so wird eine vierte Regel beim nächsten Aufrufer still
übersprungen.
Die Regel gilt dem Betrachter, nicht der Seite: das Profil eines
Neulings trägt die Anzeige für seine Besucher weiter. Tests, die ein
Mitglied Werbung sehen lassen, altern ihr Konto jetzt über
Vutuv.Factory.backdate_registration!/2 - ohne das prüften sie nur noch
die neue Sperre.
Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass
das problematisch ist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A member who registered today meets a paid stranger's pitch on their first visit to
/feedor a profile. The first days after signing up decide whether somebody stays, so the ad system now leaves a new account alone for two weeks.Vutuv.Ads.eligible?/2takes the whole%User{}instead of two hand-picked columns and readsinserted_atbesidead_seen_atandads_dismissed_on. Undergrace_days/0(14) the slot is not filled at all, house ad included. The old signature let the caller decide which columns the rule may see, which is how a fourth rule gets silently skipped.The rule is about the viewer, not the page: a newcomer's own profile still carries the ad for its visitors. No extra query —
inserted_atis on the already-loadedcurrent_user.Entry point:
lib/vutuv_web/ad_serving.ex,docs/architecture/ads.md.An AI agent wrote this text in my name. I know that is problematic.