feat: implement use case to get default conversation creation protocol (WPB-5475) #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
alexandreferris
changed the title
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara,
mchenani and
vitorhugods
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2519 +/- ##
====================================================
Coverage ? 58.38%
Complexity ? 21
====================================================
Files ? 1172
Lines ? 45349
Branches ? 4295
====================================================
Hits ? 26478
Misses ? 16947
Partials ? 1924
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
MohamadJaara
changed the title
vitorhugods
approved these changes
Feb 20, 2024
yamilmedina
approved these changes
Feb 20, 2024
alexandreferris
deleted the
fix/get_default_protocol_when_creating_group
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…l (WPB-5475) (#2519) * fix: add usecase to get default protocol * test: add tests for get default protocol usecase * fix: add get default protocol usecase to user session scope * fix: add mapping from SupportedProtocol to ConversationOptions.Protocol * fix: adjust detekt
5 tasks
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…l (WPB-5475) (#2521) * feat: implement use case to get default conversation creation protocol (WPB-5475) (#2519) * fix: add usecase to get default protocol * test: add tests for get default protocol usecase * fix: add get default protocol usecase to user session scope * fix: add mapping from SupportedProtocol to ConversationOptions.Protocol * fix: adjust detekt * empty trigger commit --------- Co-authored-by: Alexandre Ferris <[email protected]>
6 tasks
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
…l (WPB-5475) (#2521) * feat: implement use case to get default conversation creation protocol (WPB-5475) (#2519) * fix: add usecase to get default protocol * test: add tests for get default protocol usecase * fix: add get default protocol usecase to user session scope * fix: add mapping from SupportedProtocol to ConversationOptions.Protocol * fix: adjust detekt * empty trigger commit --------- Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There was no way for getting the default protocol when creating a group.
Causes (Optional)
Not implemented.
Solutions
Create a usecase (
GetDefaultProtocolUseCase) to get default protocol set by the team owner.Dependencies (Optional)
Needs releases with:
AR PR will follow as soon as this one is merged.
Testing
Test Coverage (Optional)
How to Test
Only tested in conjunction with AR, steps will be explained in AR PR.