chore: upgrade to kotlin 2.0 [WPB-8645] #2884

vitorhugods · 2024-07-17T17:51:53Z

WPB-8645 [Android] Infrastructure code and developer experience

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Upgrade to Kotlin 2.0.0

Detekt is being forced to run using 1.9.23 for now, as it can't run on 2.0.0 yet.

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2024-07-17T17:58:56Z

Test Results

3 107 tests - 151 1 112 ✅ - 2 039 5m 23s ⏱️ + 1m 14s
7 suites - 550 19 💤 - 88
7 files - 550 1 976 ❌ +1 976

For more details on these failures, see this check.

Results for commit 921e07b. ± Comparison against base commit f417fd4.

This pull request removes 3258 and adds 3107 tests. Note that renamed tests count towards both.

PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
PocIntegrationTest ‑ givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout
PocIntegrationTest ‑ givenUserWhenHandlingTextMessagesThenProcessShouldSucceed
QualifiedIdTest ‑ givenIdsWithDifferentDomains_whenEqualsIgnoringBlankDomain_thenReturnsFalse[jvm]
QualifiedIdTest ‑ givenIdsWithDifferentValues_whenEqualsIgnoringBlankDomain_thenReturnsFalse[jvm]
QualifiedIdTest ‑ givenIdsWithSameDomains_whenEqualsIgnoringBlankDomain_thenReturnsTrue[jvm]
QualifiedIdTest ‑ givenIdsWithoutDomains_whenEqualsIgnoringBlankDomain_thenReturnsTrue[jvm]
QualifiedIdTest ‑ givenOneIdWithoutDomain_whenEqualsIgnoringBlankDomain_thenReturnsTrue[jvm]
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenOkHttpSingleton_whenBuildingClearTextTrafficOkhttpClient_thenEnsureConnectionSpecClearText[jvm]
com.wire.kalium.HttpClientConnectionSpecsTest ‑ givenTheHttpClientIsCreated_ThenEnsureOnlySupportedSpecsArePresent[jvm]
…

.QualifiedIdTest ‑ givenIdsWithDifferentDomains_whenEqualsIgnoringBlankDomain_thenReturnsFalse
.QualifiedIdTest ‑ givenIdsWithDifferentValues_whenEqualsIgnoringBlankDomain_thenReturnsFalse
.QualifiedIdTest ‑ givenIdsWithSameDomains_whenEqualsIgnoringBlankDomain_thenReturnsTrue
.QualifiedIdTest ‑ givenIdsWithoutDomains_whenEqualsIgnoringBlankDomain_thenReturnsTrue
.QualifiedIdTest ‑ givenOneIdWithoutDomain_whenEqualsIgnoringBlankDomain_thenReturnsTrue
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithAccessRoleAndDeprecatedAccessRoleField_whenDecoding_thenDeprecatedFieldIsPreferred
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayloadWithDeprecatedAccessRoleField_whenDecoding_thenSuccess
com.wire.kalium.api.base.authenticated.notification.AccessUpdateTest ‑ givenPayload_whenDecoding_thenSuccess
com.wire.kalium.api.common.ACMEApiTest ‑ givenCRLWithHttpsProtocol_whenGettingClientDomainCRL_thenItShouldNotBeChanged
com.wire.kalium.api.common.ACMEApiTest ‑ givenNoLocationInHeader_whenCallingSendAcmeRequestApi_theResponseShouldBeConfigureCorrectly
…

This pull request removes 107 skipped tests and adds 19 skipped tests. Note that renamed tests count towards both.

PocIntegrationTest ‑ givenApiWhenGettingACMEDirectoriesThenReturnAsExpectedBasedOnNetworkState
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGeTrustAnchorsApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenActivationEmailWIthCode_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenRegisteringAccountWithEMail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenAValidEmail_whenSendingActivationEmail_theRequestShouldBeConfiguredCorrectly[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenRegistrationFail_whenRegisteringAccountWithEMMail_thenErrorIsPropagated[jvm]
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ givenSendActivationCodeFail_thenErrorIsPropagated[jvm]
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenDummyText_whenEncryptedAndDecryptedWithAES256_returnsOriginalText[js, browser]
…

com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingGeTrustAnchorsApi_theResponseShouldBeConfigureCorrectly
com.wire.kalium.api.common.ACMEApiTest ‑ whenCallingSendChallengeRequestApi_theResponseShouldBeConfigureCorrectly
com.wire.kalium.api.v0.user.register.RegisterApiV0Test ‑ null
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenDummyText_whenEncryptedAndDecryptedWithAES256_returnsOriginalText
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAndDecryptedWithAES256_returnsExpectedOriginalFile
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAsAFileAndDecryptedWithAES256AsData_returnsExpectedOriginalFileContent
com.wire.kalium.cryptography.CryptoUtilsTest ‑ givenSomeDummyFile_whenEncryptedAsDataAndDecryptedWithAES256AsAFile_returnsExpectedOriginalFileContent
com.wire.kalium.cryptography.CryptoUtilsTest ‑ testGivenByteArray_whenCallingCalcMd5_returnsExpectedDigest
com.wire.kalium.cryptography.CryptoUtilsTest ‑ testGivenByteArray_whenCallingCalcSHA256_returnsExpectedDigest
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAGroupConversationHasNotNewMessages_whenGettingConversationDetails_ThenReturnZeroUnreadMessageCount
…

♻️ This comment has been updated with latest results.

sonarqubecloud · 2024-07-17T20:14:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

datadog-wireapp · 2024-07-17T20:37:39Z

Datadog Report

Branch report: chore/upgrade-to-kotlin-2.0
Commit report: 995914d
Test service: kalium-jvm

❌ 1976 Failed (0 Known Flaky), 1140 Passed, 53 Skipped, 36.37s Total Time

❌ Failed Tests (1976)

This report shows up to 5 failed tests.

givenFailure_thenErrorIsPropagated[jvm] - com.wire.kalium.logic.cache.SelfConversationIdProviderTest - Details

Expand for error

 io.mockative.NoSuchMockException: A mock for the type ClientRepository was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 
         @Mock
         private val myMock = mock(classOf<ClientRepository>())
 
 io.mockative.NoSuchMockException: A mock for the type ClientRepository was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 ...

givenMLSClientHasBeenRegistered_thenMLSAndProteusSelfConversationAreReturned[jvm] - com.wire.kalium.logic.cache.SelfConversationIdProviderTest - Details

Expand for error

 io.mockative.NoSuchMockException: A mock for the type ClientRepository was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 
         @Mock
         private val myMock = mock(classOf<ClientRepository>())
 
 io.mockative.NoSuchMockException: A mock for the type ClientRepository was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 ...

givenMLSClientHasNotBeenRegistered_thenProteusSelfConversationIsReturned[jvm] - com.wire.kalium.logic.cache.SelfConversationIdProviderTest - Details

Expand for error

 io.mockative.NoSuchMockException: A mock for the type ClientRepository was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 
         @Mock
         private val myMock = mock(classOf<ClientRepository>())
 
 io.mockative.NoSuchMockException: A mock for the type ClientRepository was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 ...

givenIsNewClientTrue_whenGettingE2EIClient_newAcmeEnrollmentCalled[jvm] - com.wire.kalium.logic.client.E2EIClientProviderTest - Details

Expand for error

 io.mockative.NoSuchMockException: A mock for the type MLSClientProvider was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 
         @Mock
         private val myMock = mock(classOf<MLSClientProvider>())
 
 io.mockative.NoSuchMockException: A mock for the type MLSClientProvider was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 ...

givenMLSClientWithE2EI_whenGettingE2EIClient_callsNewActivationEnrollment[jvm] - com.wire.kalium.logic.client.E2EIClientProviderTest - Details

Expand for error

 io.mockative.NoSuchMockException: A mock for the type MLSClientProvider was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 
         @Mock
         private val myMock = mock(classOf<MLSClientProvider>())
 
 io.mockative.NoSuchMockException: A mock for the type MLSClientProvider was not generated.
 
     Make sure the property holding the mock is annotated with @Mock:
 ...

github-actions · 2024-09-12T06:51:15Z

Bencher Report

Branch	chore/upgrade-to-kotlin-2.0
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
Latency
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	653,736.85
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	338,342,380.21
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	926,433,814.80
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,620,768.09

🐰 View full continuous benchmarking report in Bencher

sonarqubecloud · 2024-09-12T08:37:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-11-08T09:56:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vitorhugods added 2 commits July 17, 2024 19:43

chore: upgrade to kotlin 2.0

fd115bf

chore: prepare for 2.0.0

5c4f9e7

github-actions bot assigned vitorhugods Jul 17, 2024

github-actions bot added 🚨 Potential breaking changes type: chore 🧹 👕 size: S labels Jul 17, 2024

chore: return supertype in actual class

b839499

MohamadJaara added the DO NOT MERGE label Jul 18, 2024

vitorhugods marked this pull request as draft July 18, 2024 08:03

echoes-hq bot added the echoes: throughput/ci-maintenance label Jul 22, 2024

Merge branch 'develop' into chore/upgrade-to-kotlin-2.0

5dc4800

fix: detekt upgrade

bf1ca06

Garzas added 4 commits November 8, 2024 09:41

Merge branch 'develop' into chore/upgrade-to-kotlin-2.0

697e075

fix

25a21f2

Merge branch 'develop' into chore/upgrade-to-kotlin-2.0

ad2ca4f

chore: kotlin and ksp update

921e07b

echoes-hq bot removed the echoes: throughput/ci-maintenance label Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to kotlin 2.0 [WPB-8645] #2884

chore: upgrade to kotlin 2.0 [WPB-8645] #2884

vitorhugods commented Jul 17, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

sonarqubecloud bot commented Jul 17, 2024

datadog-wireapp bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

sonarqubecloud bot commented Sep 12, 2024

sonarqubecloud bot commented Nov 8, 2024

chore: upgrade to kotlin 2.0 [WPB-8645] #2884

Are you sure you want to change the base?

chore: upgrade to kotlin 2.0 [WPB-8645] #2884

Conversation

vitorhugods commented Jul 17, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Jul 17, 2024 • edited Loading

Test Results

sonarqubecloud bot commented Jul 17, 2024

Quality Gate passed

datadog-wireapp bot commented Jul 17, 2024 • edited Loading

Datadog Report

❌ Failed Tests (1976)

github-actions bot commented Sep 12, 2024 • edited Loading

Bencher Report

sonarqubecloud bot commented Sep 12, 2024

Quality Gate passed

sonarqubecloud bot commented Nov 8, 2024

Quality Gate passed

vitorhugods commented Jul 17, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

datadog-wireapp bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading