fix: Properly updating draft message [WPB-14271] 🍒

[github-actions]

WPB-14271 [Android] reply draft is not cleared when clicking the x icon

This PR was automatically cherry-picked based on the following PR:

• fix: Properly updating draft message [WPB-14271] #3104

Original PR description:

---

https://wearezeta.atlassian.net/browse/WPB-14271

What's new in this PR?

Issues

We could not get rid of quoted or edited message from draft

Causes (Optional)

We were trying to update draft values to null when removing quoted or edited messages which was failing on the database query check, so in fact we're never updating actual value to a default null one

Solutions

Changed != check in database to IS NOT - comparing value and null with != is returning NULL not true or false if Im not mistaken. I've also added tests to cover other draft fields update

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 277 tests  +6   3 170 ✅ +6   4m 42s ⏱️ +22s
  557 suites ±0     107 💤 ±0 
  557 files   ±0       0 ❌ ±0 

Results for commit bf2e7db. ± Comparison against base commit 837f7ea.

This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both.

com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpserting_thenItShouldBeProperlyUpdatedInDb[jvm]

com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraftWithoutQuotedMessageId_whenUpsertingQuotedMessageId_thenItShouldBeProperlyUpdatedInDb[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpsertingDifferentEditMessageId_thenItShouldBeProperlyUpdatedInDb[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpsertingDifferentQuotedMessageId_thenItShouldBeProperlyUpdatedInDb[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpsertingEmptyMentionList_thenItShouldBeProperlyUpdatedInDb[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpsertingNullEditMessageId_thenItShouldBeProperlyUpdatedInDb[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpsertingNullQuotedMessageId_thenItShouldBeProperlyUpdatedInDb[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpsertingTextChange_thenItShouldBeProperlyUpdatedInDb[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	fix/updating-draft-message-fields-cherry-pick
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	665,428.32
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	351,617,010.98
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,316,690,575.89
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,464,965.26

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.20%. Comparing base (837f7ea) to head (bf2e7db).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3105      +/-   ##
===========================================
- Coverage    54.21%   54.20%   -0.01%     
===========================================
  Files         1196     1196              
  Lines        35596    35596              
  Branches      3625     3625              
===========================================
- Hits         19297    19296       -1     
  Misses       14900    14900              
- Partials      1399     1400       +1     

see 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837f7ea...bf2e7db. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/updating-draft-message-fields-cherry-pick
Commit report: 6e8309b
Test service: kalium-jvm

✅ 0 Failed, 3170 Passed, 107 Skipped, 33.79s Total Time