-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle needToRemoveLocally flag [WPB-14603] #3158
Conversation
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3158 +/- ##
===========================================
+ Coverage 54.11% 54.13% +0.02%
===========================================
Files 1252 1252
Lines 36519 36527 +8
Branches 3699 3703 +4
===========================================
+ Hits 19763 19775 +12
+ Misses 15331 15327 -4
Partials 1425 1425
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3239 Passed, 107 Skipped, 1m 0.09s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well-done, just one small suggestion to rename a variable that doesn't reflect its value/usage properly.
...onMain/kotlin/com/wire/kalium/logic/sync/receiver/handler/ClearConversationContentHandler.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
https://wearezeta.atlassian.net/browse/WPB-14603
What's new in this PR?
Issues
Handle
needToRemoveLocally
flag forCleared
messagesSolutions
In this PR we only define it and handle its behavior, we do NOT send it or handle sending right now
needToRemoveLocally
isfalse
ornull
, then only the conversation content is cleared, including any assets that are stored locally, but the conversation is not removed from the list.needToRemoveLocally
istrue
and the user is not a conversation member: same as option 1, but the conversation is removed.needToRemoveLocally
istrue
and the user is a conversation member: same as option 1PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.