Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle needToRemoveLocally flag [WPB-14603] #3158

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 10, 2024

StoryWPB-14603 [Android] handle needToRemoveLocally flag when reciving a cleared message

https://wearezeta.atlassian.net/browse/WPB-14603

What's new in this PR?

Issues

Handle needToRemoveLocally flag for Cleared messages

Solutions

In this PR we only define it and handle its behavior, we do NOT send it or handle sending right now

  1. If needToRemoveLocally is false or null, then only the conversation content is cleared, including any assets that are stored locally, but the conversation is not removed from the list.
  2. needToRemoveLocally is true and the user is not a conversation member: same as option 1, but the conversation is removed.
  3. needToRemoveLocally is true and the user is a conversation member: same as option 1

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Test Results

3 346 tests  +5   3 239 ✅ +5   5m 28s ⏱️ -15s
  573 suites +1     107 💤 ±0 
  573 files   +1       0 ❌ ±0 

Results for commit 375400a. ± Comparison against base commit 5396afa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.13%. Comparing base (5396afa) to head (375400a).

Files with missing lines Patch % Lines
...re/kalium/logic/data/message/ProtoContentMapper.kt 0.00% 4 Missing ⚠️
...m/wire/kalium/logic/data/message/MessageContent.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3158      +/-   ##
===========================================
+ Coverage    54.11%   54.13%   +0.02%     
===========================================
  Files         1252     1252              
  Lines        36519    36527       +8     
  Branches      3699     3703       +4     
===========================================
+ Hits         19763    19775      +12     
+ Misses       15331    15327       -4     
  Partials      1425     1425              
Files with missing lines Coverage Δ
...re/conversation/ClearConversationContentUseCase.kt 100.00% <100.00%> (ø)
...eceiver/handler/ClearConversationContentHandler.kt 100.00% <100.00%> (+100.00%) ⬆️
...m/wire/kalium/logic/data/message/MessageContent.kt 0.00% <0.00%> (ø)
...re/kalium/logic/data/message/ProtoContentMapper.kt 65.04% <0.00%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5396afa...375400a. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 10, 2024

Datadog Report

Branch report: feat/need-to-remove-locally-flag
Commit report: 065eb66
Test service: kalium-jvm

✅ 0 Failed, 3239 Passed, 107 Skipped, 1m 0.09s Total Time

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-done, just one small suggestion to rename a variable that doesn't reflect its value/usage properly.

@m-zagorski m-zagorski added this pull request to the merge queue Dec 16, 2024
Merged via the queue into develop with commit 6fb2177 Dec 16, 2024
29 checks passed
@m-zagorski m-zagorski deleted the feat/need-to-remove-locally-flag branch December 16, 2024 13:50
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants