fix: do not commit User and Client upserts if nothing has changed [WPB-15055]

[saleniuk]

WPB-15055 [Android] Crash when opening connection request from paginated list

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

When the user data is outdated, the app fetches it again and makes an upsert to the database, but even if there are no changes in the data at all, the insert query is still executed and it notifies all other queries unnecessarily.

Solutions

Make it so that when the app upserts User or Client data and there are absolutely no changes, then rollback that query to not make all other queries that depend on that one dirty.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 347 tests  +4   3 240 ✅ +4   5m 32s ⏱️ -27s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit ccdcb19. ± Comparison against base commit da1e7eb.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: fix/do-not-commit-user-and-client-upserts-if-nothing-has-changed
Commit report: 4876e4b
Test service: kalium-jvm

✅ 0 Failed, 3240 Passed, 107 Skipped, 1m 0.87s Total Time

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.16%. Comparing base (da1e7eb) to head (ccdcb19).

Files with missing lines	Patch %	Lines
...ire/kalium/persistence/dao/client/ClientDAOImpl.kt	73.33%	3 Missing and 1 partial ⚠️
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt	93.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3188      +/-   ##
=====================================================
+ Coverage              54.15%   54.16%   +0.01%     
=====================================================
  Files                   1250     1250              
  Lines                  36477    36495      +18     
  Branches                3696     3704       +8     
=====================================================
+ Hits                   19754    19769      +15     
- Misses                 15295    15296       +1     
- Partials                1428     1430       +2     

Files with missing lines	Coverage Δ
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt	52.58% <93.33%> (+0.10%)	⬆️
...ire/kalium/persistence/dao/client/ClientDAOImpl.kt	77.16% <73.33%> (+2.16%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1e7eb...ccdcb19. Read the comment docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud