Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merging issue #WPB-11723 #3199

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix: Merging issue #WPB-11723 #3199

merged 2 commits into from
Dec 27, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 26, 2024

StoryWPB-11723 [Android] Playback improvement - 1 - Scroll / Duration / Speed

What's new in this PR?

Issues

In #3191 when merging fresh develop into branch I removed something that shouldn't.

Causes (Optional)

Didn't pay enough attention while merging.

Solutions

Fix it

@borichellow borichellow self-assigned this Dec 26, 2024
@borichellow borichellow changed the title fix: Merging issue fix: Merging issue #WPB-11723 Dec 26, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 26, 2024
Copy link
Contributor

github-actions bot commented Dec 26, 2024

Test Results

3 378 tests  ±0   3 271 ✅ ±0   5m 30s ⏱️ -3s
  580 suites ±0     107 💤 ±0 
  580 files   ±0       0 ❌ ±0 

Results for commit b2deb5f. ± Comparison against base commit 72b6d4c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 26, 2024

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.10%. Comparing base (72b6d4c) to head (b2deb5f).

Files with missing lines Patch % Lines
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3199      +/-   ##
===========================================
- Coverage    54.12%   54.10%   -0.02%     
===========================================
  Files         1264     1264              
  Lines        36793    36800       +7     
  Branches      3735     3735              
===========================================
- Hits         19914    19911       -3     
- Misses       15439    15449      +10     
  Partials      1440     1440              
Files with missing lines Coverage Δ
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b6d4c...b2deb5f. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 26, 2024

Datadog Report

Branch report: fix/merging_issue
Commit report: 4e69e68
Test service: kalium-jvm

✅ 0 Failed, 3271 Passed, 107 Skipped, 1m 1.29s Total Time

@yamilmedina yamilmedina added this pull request to the merge queue Dec 27, 2024
Merged via the queue into develop with commit 6ddef73 Dec 27, 2024
23 checks passed
@yamilmedina yamilmedina deleted the fix/merging_issue branch December 27, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants