Skip to content

Conversation

@ohassine
Copy link
Member

@ohassine ohassine commented Aug 13, 2025

TaskWPB-19215 [Android] Update Cells SDK to 0.1.1-alpha15


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Should be merged after #3577

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Test Results

0 tests   - 3 867   0 ✅  - 3 756   0s ⏱️ - 6m 8s
0 suites  -   664   0 💤  -   111 
0 files    -   664   0 ❌ ±    0 

Results for commit 792bafc. ± Comparison against base commit d30f3df.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the dependency PR merge on develop. #3577

This update of ktor breaks the minification while building a release. Please verify that we can build a release before merging this 🙏

You can try on android-reloaded to run, to verify that the bump of ktor is functional
:app:minifyInternalCompatWithR8

@ohassine
Copy link
Member Author

Reverted the dependency PR merge on develop. #3577

This update of ktor breaks the minification while building a release. Please verify that we can build a release before merging this 🙏

You can try on android-reloaded to run, to verify that the bump of ktor is functional :app:minifyInternalCompatWithR8

Thanks for flagging the minification issue — I raised another PR fixing it.
Just a heads-up — in the future, I’d appreciate it if we could sync before reverting one of my commits. A quick message would’ve helped clarify things faster.

@ohassine ohassine closed this Aug 26, 2025
@ohassine ohassine reopened this Aug 26, 2025
@sonarqubecloud
Copy link

@ohassine
Copy link
Member Author

Closing it as it will be updated here #3590

@ohassine ohassine closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants