feat: support qualified client id from wire clients with : as delimiter

Author: beltram

acme/src/identifier.rs

@@ -10,7 +10,7 @@ pub enum AcmeIdentifier {
 
 impl AcmeIdentifier {
     pub fn try_new(display_name: String, domain: String, client_id: ClientId, handle: String) -> RustyAcmeResult<Self> {
-        let client_id = client_id.to_subject();
+        let client_id = client_id.to_uri();
         let identifier = WireIdentifier {
             display_name,
             domain,

acme/src/order.rs

@@ -1,15 +1,16 @@
-use crate::prelude::*;
 use rusty_jwt_tools::prelude::*;
 
+use crate::prelude::*;
+
 // Order creation
 impl RustyAcme {
     /// create a new order
     /// see [RFC 8555 Section 7.4](https://www.rfc-editor.org/rfc/rfc8555.html#section-7.4).
     #[allow(clippy::too_many_arguments)]
     pub fn new_order_request(
-        display_name: String,
+        display_name: &str,
         client_id: ClientId,
-        handle: String,
+        handle: &str,
         expiry: core::time::Duration,
         directory: &AcmeDirectory,
         account: &AcmeAccount,
@@ -21,7 +22,12 @@ impl RustyAcme {
         let acct_url = account.acct_url()?;
 
         let domain = client_id.domain.clone();
-        let identifiers = vec![AcmeIdentifier::try_new(display_name, domain, client_id, handle)?];
+        let identifiers = vec![AcmeIdentifier::try_new(
+            display_name.to_string(),
+            domain,
+            client_id,
+            handle.to_string(),
+        )?];
         let not_before = time::OffsetDateTime::now_utc();
         let not_after = not_before + expiry;
         let payload = AcmeOrderRequest {
@@ -231,10 +237,11 @@ pub enum AcmeOrderStatus {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
     use serde_json::json;
     use wasm_bindgen_test::*;
 
+    use super::*;
+
     wasm_bindgen_test_configure!(run_in_browser);
 
     mod json {

cli/src/access_generate.rs

@@ -57,7 +57,7 @@ impl AccessGenerate {
             extra_claims: None,
         };
         let nonce: BackendNonce = self.nonce.into();
-        let client_id: ClientId = self.client_id.as_str().try_into().expect("Invalid 'client_id'");
+        let client_id = ClientId::try_from_uri(&self.client_id).expect("Invalid 'client_id'");
         let expiry = core::time::Duration::from_secs(self.expiry);
 
         let client_dpop_token =

cli/src/access_verify.rs

@@ -46,7 +46,7 @@ impl AccessVerify {
             .trim()
             .to_string();
 
-        let client_id: ClientId = self.client_id.as_str().try_into().expect("Invalid 'client_id'");
+        let client_id = ClientId::try_from_uri(&self.client_id).expect("Invalid 'client_id'");
         let challenge: AcmeNonce = self.challenge.into();
         let (_, backend_pk) = parse_public_key_pem(read_file(Some(&self.key)).unwrap());
 

e2e-identity/README.md

@@ -115,16 +115,16 @@ impl RustyE2eIdentity {
     #[allow(clippy::too_many_arguments)]
     pub fn acme_new_order_request(
         &self,
-        display_name: String,
-        client_id: String,
-        handle: String,
+        display_name: &str,
+        client_id: &str,
+        handle: &str,
         expiry: core::time::Duration,
         directory: &AcmeDirectory,
         account: &E2eiAcmeAccount,
         previous_nonce: String,
     ) -> E2eIdentityResult<Json> {
         let account = serde_json::from_value(account.clone().into())?;
-        let client_id = ClientId::try_from_qualified(client_id.as_str())?;
+        let client_id = ClientId::try_from_qualified(client_id)?;
         let order_req = RustyAcme::new_order_request(
             display_name,
             client_id,

e2e-identity/src/lib.rs

@@ -20,7 +20,7 @@ fn e2e_api() {
         let user_id = base64::prelude::BASE64_URL_SAFE_NO_PAD.encode(user_id.to_string());
         let client_id = random::<u64>();
         let domain = "example.org";
-        let qualified_client_id = format!("{user_id}/{client_id:x}@{domain}");
+        let qualified_client_id = format!("{user_id}:{client_id:x}@{domain}");
 
         let display_name = "Smith, Alice M (QA)".to_string();
         let qualified_handle = format!("alice.smith.qa@{domain}");
@@ -73,9 +73,9 @@ fn e2e_api() {
             let expiry = core::time::Duration::from_secs(3600); // 1h
             let _order_request = enrollment
                 .acme_new_order_request(
-                    display_name,
-                    qualified_client_id.clone(),
-                    qualified_handle,
+                    &display_name,
+                    &qualified_client_id,
+                    &qualified_handle,
                     expiry,
                     &directory,
                     &account,

e2e-identity/tests/api.rs

@@ -108,7 +108,7 @@ impl<'a> E2eTest<'a> {
                 email: email.to_string(),
                 password: password.to_string(),
                 domain: domain.to_string(),
-                sub: sub.to_subject(),
+                sub: sub.to_uri(),
             },
             dex_cfg: DexCfg {
                 host: dex_host,

e2e-identity/tests/utils/cfg.rs

@@ -136,9 +136,9 @@ impl<'a> E2eTest<'a> {
         self.display_step("create a new order");
         let expiry = core::time::Duration::from_secs(3600); // 1h
         let order_request = RustyAcme::new_order_request(
-            self.display_name.clone(),
+            &self.display_name,
             self.sub.clone(),
-            self.handle.clone(),
+            &self.handle,
             expiry,
             directory,
             account,
@@ -267,7 +267,7 @@ impl<'a> E2eTest<'a> {
         let b64 = |v: &str| base64::prelude::BASE64_URL_SAFE_NO_PAD.encode(v);
 
         // cheat to share test context
-        ctx_store("client-id", self.sub.to_subject());
+        ctx_store("client-id", self.sub.to_uri());
         ctx_store("backend-kp", self.backend_kp.to_string());
         ctx_store("hash-alg", self.hash_alg.to_string());
         ctx_store("wire-server-uri", self.wire_server_uri());

e2e-identity/tests/utils/fmk.rs

@@ -47,7 +47,7 @@ pub async fn wire_api(req: Request<Body>) -> Result<Response<Body>, hyper::Error
 
 fn generate_access_token(dpop: &str, nonce: BackendNonce) -> serde_json::Value {
     let client_id = ctx_get("client-id").unwrap();
-    let client_id: ClientId = client_id.as_str().try_into().unwrap();
+    let client_id = ClientId::try_from_uri(&client_id).unwrap();
     let backend_kp: Pem = ctx_get("backend-kp").unwrap().into();
     let hash_alg: HashAlgorithm = ctx_get("hash-alg").unwrap().parse().unwrap();
     let htu: Htu = ctx_get("wire-server-uri").unwrap().as_str().try_into().unwrap();