Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow missing docs in tests #277

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

SimonThormeyer
Copy link
Contributor

@SimonThormeyer SimonThormeyer commented Dec 2, 2024

After upgrading to Rust 1.83, this rule is enforced in a different way, which requires us to change it for tests.

What's new in this PR


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SimonThormeyer SimonThormeyer requested a review from a team as a code owner December 2, 2024 08:45
After upgrading to Rust 1.83, `missing_docs` is enforced in a different way, which requires us to change it for tests.
@SimonThormeyer SimonThormeyer force-pushed the simon/chore/fix-new-lints branch from 0ff8f30 to 27a05d0 Compare December 2, 2024 08:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (5870dec) to head (27a05d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files          49       49           
  Lines        4323     4323           
=======================================
  Hits         3460     3460           
  Misses        863      863           

@SimonThormeyer SimonThormeyer merged commit f0166bd into main Dec 2, 2024
16 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/chore/fix-new-lints branch December 2, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants