Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to kotlin 2.0 #3189

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Upgrade to Kotlin 2.0.0

Detekt is being forced to run using 1.9.23 for now, as it can't run on 2.0.0 yet.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods force-pushed the chore/upgrade-to-kotlin-2.0 branch from 5b2d23c to bc526a5 Compare July 17, 2024 17:53
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3189.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3189.apk is available for download

@wireapp wireapp deleted a comment from pull-request-size bot Jul 18, 2024
@vitorhugods vitorhugods marked this pull request as draft July 18, 2024 08:02
Copy link

Copy link

sonarqubecloud bot commented Nov 8, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.91%. Comparing base (63b0890) to head (a9d979b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3189      +/-   ##
===========================================
- Coverage    45.98%   45.91%   -0.08%     
===========================================
  Files          472      477       +5     
  Lines        15947    16225     +278     
  Branches      2630     2649      +19     
===========================================
+ Hits          7334     7449     +115     
- Misses        7855     8008     +153     
- Partials       758      768      +10     

see 196 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b0890...a9d979b. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Built wire-android-staging-compat-pr-3189.apk is available for download

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Built wire-android-dev-debug-pr-3189.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants