Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrong url when opening team management after migration - cherrypick (WPB-14872) #3720

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 9, 2024

TaskWPB-14872 [Android] Wrong URL when opening team management after migration from button


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #3731

Needs releases with:

  • GitHub link to other pull request

Needs wireapp/kalium#3157

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, m-zagorski, alexandreferris, borichellow, saleniuk and mathias-niboulies and removed request for a team December 11, 2024 08:39
@vitorhugods vitorhugods changed the title feat: Wrong url when opening team management after migration (WPB-14872) fix: wrong url when opening team management after migration (WPB-14872) Dec 11, 2024
@yamilmedina yamilmedina changed the base branch from develop to release/candidate December 11, 2024 10:16
@yamilmedina yamilmedina changed the base branch from release/candidate to develop December 11, 2024 10:16
@yamilmedina
Copy link
Contributor

@ohassine can you please cherry pick this to release/candidate branch, we need it for 4.10 🙏

@ohassine ohassine changed the title fix: wrong url when opening team management after migration (WPB-14872) chore: wrong url when opening team management after migration (WPB-14872) Dec 11, 2024
…ning-team-management-after-migration

# Conflicts:
#	kalium
@ohassine ohassine requested a review from yamilmedina December 11, 2024 14:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.60%. Comparing base (e6d8091) to head (4ea2d65).

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 78.57% 3 Missing ⚠️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3720      +/-   ##
===========================================
+ Coverage    45.57%   45.60%   +0.02%     
===========================================
  Files          476      476              
  Lines        16105    16118      +13     
  Branches      2736     2736              
===========================================
+ Hits          7340     7350      +10     
- Misses        7998     8002       +4     
+ Partials       767      766       -1     
Files with missing lines Coverage Δ
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.29% <0.00%> (-0.64%) ⬇️
...serprofile/teammigration/TeamMigrationViewModel.kt 90.19% <78.57%> (-4.55%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d8091...4ea2d65. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3720.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3720.apk is available for download

@ohassine ohassine changed the title chore: wrong url when opening team management after migration (WPB-14872) chore: wrong url when opening team management after migration - cherrypick (WPB-14872) Dec 13, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 13, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants