Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track ended call segmentation [#WPB-14256] #3756

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 18, 2024

StoryWPB-14256 [Android] Call end - Event and segmentation

https://wearezeta.atlassian.net/browse/WPB-14256

What's new in this PR?

Issues

Missing tracking for ended call.

Solutions

Map RecentlyEndedCallMetadata into the analytics segmentation and send the event to countly


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.74%. Comparing base (e0e5c8b) to head (2565ffb).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3756      +/-   ##
===========================================
- Coverage    45.76%   45.74%   -0.02%     
===========================================
  Files          477      477              
  Lines        16199    16209      +10     
  Branches      2744     2746       +2     
===========================================
+ Hits          7413     7415       +2     
- Misses        8017     8024       +7     
- Partials       769      770       +1     
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt 71.53% <100.00%> (ø)
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e5c8b...2565ffb. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3756.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3756.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3756.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3756.apk is available for download

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically good, but have a small code-style suggestion :)

app/src/main/kotlin/com/wire/android/WireApplication.kt Outdated Show resolved Hide resolved
Copy link
Contributor

Built wire-android-staging-compat-pr-3756.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3756.apk is available for download

@m-zagorski m-zagorski added this pull request to the merge queue Dec 23, 2024
Merged via the queue into develop with commit 8d9c35d Dec 23, 2024
13 of 14 checks passed
@m-zagorski m-zagorski deleted the feat/track-ended-call branch December 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants