Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delete group conversation locally [#WPB-11556] #3774

Merged
merged 7 commits into from
Dec 31, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 30, 2024

StoryWPB-11556 [Android] Remove a group from my conversation list after leaving it

https://wearezeta.atlassian.net/browse/WPB-11556

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@m-zagorski m-zagorski requested a review from saleniuk December 30, 2024 13:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 10.71429% with 50 lines in your changes missing coverage. Please review.

Project coverage is 45.77%. Comparing base (8847c15) to head (ba5ae5d).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...kmanager/worker/DeleteConversationLocallyWorker.kt 0.00% 31 Missing ⚠️
...ome/conversationslist/ConversationListViewModel.kt 14.28% 12 Missing ⚠️
...in/com/wire/android/ui/home/HomeSnackBarMessage.kt 0.00% 4 Missing ⚠️
.../com/wire/android/workmanager/WireWorkerFactory.kt 0.00% 2 Missing ⚠️
...ome/conversationslist/ConversationsDialogsState.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3774      +/-   ##
===========================================
+ Coverage    45.70%   45.77%   +0.06%     
===========================================
  Files          477      483       +6     
  Lines        16223    16498     +275     
  Branches      2746     2783      +37     
===========================================
+ Hits          7415     7552     +137     
- Misses        8038     8165     +127     
- Partials       770      781      +11     
Files with missing lines Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 67.20% <100.00%> (+0.17%) ⬆️
...erprofile/other/OtherUserProfileScreenViewModel.kt 59.50% <100.00%> (+0.20%) ⬆️
...ome/conversationslist/ConversationsDialogsState.kt 0.00% <0.00%> (ø)
.../com/wire/android/workmanager/WireWorkerFactory.kt 0.00% <0.00%> (ø)
...in/com/wire/android/ui/home/HomeSnackBarMessage.kt 7.69% <0.00%> (-0.88%) ⬇️
...ome/conversationslist/ConversationListViewModel.kt 31.41% <14.28%> (-1.25%) ⬇️
...kmanager/worker/DeleteConversationLocallyWorker.kt 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8847c15...ba5ae5d. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3774.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3774.apk is available for download

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, it would be nice to add some kdocs in the worker, so we have context for the future :D

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@m-zagorski m-zagorski added this pull request to the merge queue Dec 31, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3774.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3774.apk is available for download

Merged via the queue into develop with commit 06d0b4d Dec 31, 2024
13 of 14 checks passed
@m-zagorski m-zagorski deleted the feat/delete-group-conversation-locally branch December 31, 2024 12:56
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants