-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delete group conversation locally [#WPB-11556] #3774
Conversation
app/src/main/kotlin/com/wire/android/ui/calling/ongoing/OngoingCallViewModel.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3774 +/- ##
===========================================
+ Coverage 45.70% 45.77% +0.06%
===========================================
Files 477 483 +6
Lines 16223 16498 +275
Branches 2746 2783 +37
===========================================
+ Hits 7415 7552 +137
- Misses 8038 8165 +127
- Partials 770 781 +11
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3774.apk is available for download |
Built wire-android-dev-debug-pr-3774.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good, it would be nice to add some kdocs in the worker, so we have context for the future :D
app/src/main/kotlin/com/wire/android/workmanager/worker/DeleteConversationLocallyWorker.kt
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Built wire-android-staging-compat-pr-3774.apk is available for download |
Built wire-android-dev-debug-pr-3774.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-11556
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.