Skip to content

feat(channels): add filter capability for channels (WPB-15863)#3900

Merged
yamilmedina merged 5 commits intodevelopfrom
feat/channels-filter
Mar 13, 2025
Merged

feat(channels): add filter capability for channels (WPB-15863)#3900
yamilmedina merged 5 commits intodevelopfrom
feat/channels-filter

Conversation

@yamilmedina
Copy link
Copy Markdown
Contributor

@yamilmedina yamilmedina commented Mar 5, 2025

StoryWPB-15863 [Android] Add channels as an option in the filter menu


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Add to the conversations filters UI the ability to select channels
  • Add empty state for channels filter

Solutions

For now the model is simplified to get it from Filter and the filter just does nothing, we need to wait to have the full model in kalium to actually filter in DB.

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2025-03-05.at.15.17.10.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (422cbfb) to head (06f1218).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ome/conversationslist/ConversationListViewModel.kt 33.33% 2 Missing ⚠️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% 2 Missing ⚠️
.../wire/android/util/debug/FeatureVisibilityFlags.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3900      +/-   ##
===========================================
- Coverage    45.59%   45.59%   -0.01%     
===========================================
  Files          491      491              
  Lines        17078    17087       +9     
  Branches      2845     2851       +6     
===========================================
+ Hits          7786     7790       +4     
- Misses        8500     8505       +5     
  Partials       792      792              
Files with missing lines Coverage Δ
...tions/usecase/GetConversationsFromSearchUseCase.kt 81.81% <100.00%> (+0.33%) ⬆️
...ome/conversationslist/model/ConversationsSource.kt 86.66% <100.00%> (+2.05%) ⬆️
.../wire/android/util/debug/FeatureVisibilityFlags.kt 0.00% <0.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt 33.21% <33.33%> (+<0.01%) ⬆️
...tionslist/filter/ConversationFilterSheetContent.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422cbfb...06f1218. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

Built wire-android-staging-compat-pr-3900.apk is available for download

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

Built wire-android-dev-debug-pr-3900.apk is available for download

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2025

Built wire-android-staging-compat-pr-3900.apk is available for download

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2025

Built wire-android-dev-debug-pr-3900.apk is available for download

@sonarqubecloud
Copy link
Copy Markdown

@yamilmedina yamilmedina enabled auto-merge March 13, 2025 16:39
@yamilmedina yamilmedina added this pull request to the merge queue Mar 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Built wire-android-staging-compat-pr-3900.apk is available for download

@github-actions
Copy link
Copy Markdown
Contributor

Built wire-android-dev-debug-pr-3900.apk is available for download

Merged via the queue into develop with commit af8ab31 Mar 13, 2025
@yamilmedina yamilmedina deleted the feat/channels-filter branch March 13, 2025 17:30
saleniuk added a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants