Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(channels): distinguish channels in conversation list [WPB-15865] #3924

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Mar 19, 2025

StoryWPB-15865 [Android] Show channels in conversation list


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Channels are properly displayed in Conversation List, with the correct icon.

Introduced the isChannel attribute to distinguish channel conversations across data models and UI components for the conversation list. Updated ConversationMapper and related UI logic to handle channel-specific behavior, including rendering appropriate avatars. Added previews to validate the new functionality in different states.

Testing

Not added, as it only changes UI.

Attachments

Dark Theme Light Theme
Screenshot_20250319-114953 Screenshot_20250319-115046

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Introduced the `isChannel` attribute to distinguish channel conversations across data models and UI components. Updated `ConversationMapper` and related UI logic to handle channel-specific behavior, including rendering appropriate avatars. Added previews to validate the new functionality in different states.
@vitorhugods vitorhugods enabled auto-merge March 19, 2025 12:30
@vitorhugods vitorhugods force-pushed the channels/feat/display-channels-in-conversation-list branch from 7eaf94a to 3a77299 Compare March 19, 2025 12:30
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@vitorhugods vitorhugods added this pull request to the merge queue Mar 19, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.60%. Comparing base (ef3fdcb) to head (99bd1c0).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3924   +/-   ##
========================================
  Coverage    45.59%   45.60%           
========================================
  Files          492      492           
  Lines        17090    17092    +2     
  Branches      2852     2852           
========================================
+ Hits          7793     7795    +2     
  Misses        8505     8505           
  Partials       792      792           
Files with missing lines Coverage Δ
...tlin/com/wire/android/mapper/ConversationMapper.kt 64.86% <100.00%> (+0.31%) ⬆️
...i/home/conversationslist/model/ConversationItem.kt 55.05% <100.00%> (+0.51%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3fdcb...99bd1c0. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-3924.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3924.apk is available for download

Merged via the queue into develop with commit 5135cfb Mar 19, 2025
11 of 12 checks passed
@vitorhugods vitorhugods deleted the channels/feat/display-channels-in-conversation-list branch March 19, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants