Skip to content

Conversation

alexandreferris
Copy link
Member

  • On Backend API v9 MessageCount was removed

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On API v9 MessageCount was removed and thus causing and endless closing and reconnection of the websocket

Solutions

Remove sending of ack_message_count and MessageCount in general

* On Backend API v9 MessageCount was removed
@alexandreferris alexandreferris requested a review from a team as a code owner July 1, 2025 13:19
@alexandreferris alexandreferris self-assigned this Jul 1, 2025
* Remove unused AcknowledgeType
Copy link

@olanokhin olanokhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Everything clean!

@alexandreferris alexandreferris merged commit 1316b5f into main Jul 1, 2025
2 checks passed
@alexandreferris alexandreferris deleted the chore/remove_websocket_message_count branch July 1, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants