Skip to content

Conversation

alexandreferris
Copy link
Member

  • Bring back MessageCount("message_count") response class
  • Listen in websocket frame but ignore ACK

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Despite not needing to send an ACK for MessageCount("message_count") from the websocket anymore we still need to receive it (but ignore) until wireapp/wire-server#4631 is merged.

Solutions

  • Update backend version to v9
  • Bring back MessageCount
  • Listen to MessageCount from the websocket but ignore/don't send an ACK

* Bring back MessageCount("message_count") response class
* Listen in websocket frame but ignore ACK
@alexandreferris alexandreferris requested a review from a team as a code owner July 2, 2025 09:54
@alexandreferris alexandreferris self-assigned this Jul 2, 2025
@alexandreferris alexandreferris merged commit 2a01732 into main Jul 2, 2025
2 checks passed
@alexandreferris alexandreferris deleted the chore/ignore_websocket_message_count branch July 2, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants