Skip to content

Conversation

spoonman01
Copy link
Collaborator

  • Documentation refactorings and typo fix after Baris feedback

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

SDK still referenced Chala env and had some typos

Solutions

Move default to Staging and fix typos


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

- Documentation refactorings and typo fix after Baris feedback
@spoonman01 spoonman01 self-assigned this Aug 19, 2025
@spoonman01 spoonman01 requested a review from a team as a code owner August 19, 2025 13:08
Comment on lines 70 to 74
WIRE_SDK_USER_ID=abcd-1234-efgh-5678
[email protected]
WIRE_SDK_PASSWORD=randomPassword
WIRE_SDK_CLIENT=dd228f6343d3916
WIRE_SDK_ENVIRONMENT=my.domain.link
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my PR : #164 I moved this Environment variables to APPLICATION.md when explaining about how to run the SDK

@spoonman01 spoonman01 merged commit 450ff37 into main Aug 19, 2025
2 checks passed
@alexandreferris alexandreferris deleted the chore-move-to-staging branch August 19, 2025 13:29
@bbaarriiss
Copy link
Contributor

Thanks Luca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants